QuickCopy & fix NoteEffects

This commit is contained in:
SoulliesOfficial
2025-02-21 14:08:32 -05:00
parent 70eddeb881
commit 187b2efdad
28 changed files with 277 additions and 60 deletions

View File

@@ -11,10 +11,10 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
public class BasicNoteBadExpand : NoteBadEffect
{
Renderer noteMainRenderer;
public BasicNoteBadExpand(NoteBase note)
public BasicNoteBadExpand(NoteVisualBase noteVisual)
{
this.note = note;
this.noteVisual = note.noteVisual.GetComponent<BasicNoteVisual>();
this.note = noteVisual.note;
this.noteVisual = note.noteVisual;
this.noteMainRenderer = noteVisual.noteMain.GetComponent<Renderer>();
this.effectTime = 0.1f;
}
@@ -59,9 +59,9 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
}
public override EffectBase ConvertToGameType()
public override EffectBase ConvertToGameType(GameElement attachedGameElement)
{
return new BasicNoteBadExpand(GameElement_BM.GetElement(attachedNoteID) as NoteBase);
return new BasicNoteBadExpand(attachedGameElement as NoteVisualBase);
}
}
}

View File

@@ -12,12 +12,12 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
{
public class BasicNoteGenerateExpand : NoteGenerateEffect
{
public BasicNoteGenerateExpand(NoteBase note)
public BasicNoteGenerateExpand(NoteVisualBase noteVisual)
{
this.note = note;
this.note = noteVisual.note;
this.noteVisual = noteVisual;
this.generateTime = 1f;
this.effectTime = 0.1f;
this.noteVisual = note.noteVisual.GetComponent<BasicNoteVisual>();
}
public override void Recover()
@@ -61,9 +61,9 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
}
public override EffectBase ConvertToGameType()
public override EffectBase ConvertToGameType(GameElement attachedGameElement)
{
return new BasicNoteGenerateExpand(GameElement_BM.GetElement(attachedNoteID) as NoteBase);
return new BasicNoteGenerateExpand(attachedGameElement as NoteVisualBase);
}
}
}

View File

@@ -13,10 +13,10 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
{
private GameObject effectRing;
public BasicNoteGoodBurst(NoteBase note)
public BasicNoteGoodBurst(NoteVisualBase noteVisual)
{
this.note = note;
this.noteVisual = note.noteVisual.GetComponent<BasicNoteVisual>();
this.note = noteVisual.note;
this.noteVisual = noteVisual;
this.effectRing = noteVisual.effectPartList[0];
this.effectTime = 0.1f;
}
@@ -64,9 +64,9 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
}
public override EffectBase ConvertToGameType()
public override EffectBase ConvertToGameType(GameElement attachedGameElement)
{
return new BasicNoteGoodBurst(GameElement_BM.GetElement(attachedNoteID) as NoteBase);
return new BasicNoteGoodBurst(attachedGameElement as NoteVisualBase);
}
}
}

View File

@@ -12,10 +12,10 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
{
Renderer noteMainRenderer;
public BasicNoteMissPale(NoteBase note)
public BasicNoteMissPale(NoteVisualBase noteVisual)
{
this.note = note;
this.noteVisual = note.noteVisual.GetComponent<BasicNoteVisual>();
this.note = noteVisual.note;
this.noteVisual = noteVisual;
this.noteMainRenderer = noteVisual.noteMain.GetComponent<Renderer>();
this.effectTime = 0.2f;
}
@@ -59,10 +59,10 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
{
}
public override EffectBase ConvertToGameType()
public override EffectBase ConvertToGameType(GameElement attachedGameElement)
{
return new BasicNoteMissPale(GameElement_BM.GetElement(attachedNoteID) as NoteBase);
return new BasicNoteMissPale(attachedGameElement as NoteVisualBase);
}
}
}

View File

@@ -13,10 +13,10 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
{
private GameObject effectRing;
public BasicNotePerfectBurst(NoteBase note)
public BasicNotePerfectBurst(NoteVisualBase noteVisual)
{
this.note = note;
this.noteVisual = note.noteVisual.GetComponent<BasicNoteVisual>();
this.note = noteVisual.note;
this.noteVisual = noteVisual;
this.effectRing = noteVisual.effectPartList[0];
this.effectTime = 0.1f;
}
@@ -64,9 +64,9 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
}
public override EffectBase ConvertToGameType()
public override EffectBase ConvertToGameType(GameElement attachedGameElement)
{
return new BasicNotePerfectBurst(GameElement_BM.GetElement(attachedNoteID) as NoteBase);
return new BasicNotePerfectBurst(attachedGameElement as NoteVisualBase);
}
}
}

View File

@@ -22,11 +22,11 @@ namespace Ichni.RhythmGame.ThemeBundles.Basic
if (isFirstGenerated)
{
noteVisual.effectSubmodule.effectCollection["Generate"].Add(new BasicNoteGenerateExpand(noteVisual.note));
noteVisual.effectSubmodule.effectCollection["Perfect"].Add(new BasicNotePerfectBurst(noteVisual.note));
noteVisual.effectSubmodule.effectCollection["Good"].Add(new BasicNoteGoodBurst(noteVisual.note));
noteVisual.effectSubmodule.effectCollection["Bad"].Add(new BasicNoteBadExpand(noteVisual.note));
noteVisual.effectSubmodule.effectCollection["Miss"].Add(new BasicNoteMissPale(noteVisual.note));
noteVisual.effectSubmodule.effectCollection["Generate"].Add(new BasicNoteGenerateExpand(noteVisual));
noteVisual.effectSubmodule.effectCollection["Perfect"].Add(new BasicNotePerfectBurst(noteVisual));
noteVisual.effectSubmodule.effectCollection["Good"].Add(new BasicNoteGoodBurst(noteVisual));
noteVisual.effectSubmodule.effectCollection["Bad"].Add(new BasicNoteBadExpand(noteVisual));
noteVisual.effectSubmodule.effectCollection["Miss"].Add(new BasicNoteMissPale(noteVisual));
}
return noteVisual;